Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle ESP32: Add bridge app example to ESP32 #8369

Closed
wants to merge 3 commits into from
Closed

Restyle ESP32: Add bridge app example to ESP32 #8369

wants to merge 3 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jul 14, 2021

A duplicate of #8368 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions 
    ```console
git remote add upstream https://github.com/project-chip/connectedhomeip.git
git fetch upstream pull/<this PR number>/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Jul 14, 2021
@todo
Copy link

todo bot commented Jul 14, 2021

(cecille): Fix for the case where BLE and SoftAP are both enabled.`

connectedhomeip/examples/bridge-app/esp32/main/CHIPDeviceManager.cpp

Lines 67 to 77 in 10d2314

// TODO(cecille): Fix for the case where BLE and SoftAP are both enabled.`
ConnectivityMgr().SetBLEAdvertisingEnabled(false);
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}
else
{
// If rendezvous is bypassed, enable SoftAP so that the device can still
// be communicated with via its SoftAP as needed.
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}

This comment was generated by todo based on a TODO comment in 10d2314 in #8369. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-8368 branch from 10d2314 to 9dad17f Compare July 14, 2021 10:37
@todo
Copy link

todo bot commented Jul 14, 2021

(cecille): Fix for the case where BLE and SoftAP are both enabled.`

connectedhomeip/examples/bridge-app/esp32/main/CHIPDeviceManager.cpp

Lines 67 to 77 in 9dad17f

// TODO(cecille): Fix for the case where BLE and SoftAP are both enabled.`
ConnectivityMgr().SetBLEAdvertisingEnabled(false);
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}
else
{
// If rendezvous is bypassed, enable SoftAP so that the device can still
// be communicated with via its SoftAP as needed.
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}

This comment was generated by todo based on a TODO comment in 9dad17f in #8369. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-8368 branch from 9dad17f to d8e7a75 Compare July 14, 2021 11:18
@todo
Copy link

todo bot commented Jul 14, 2021

(cecille): Fix for the case where BLE and SoftAP are both enabled.`

connectedhomeip/examples/bridge-app/esp32/main/CHIPDeviceManager.cpp

Lines 67 to 77 in d8e7a75

// TODO(cecille): Fix for the case where BLE and SoftAP are both enabled.`
ConnectivityMgr().SetBLEAdvertisingEnabled(false);
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}
else
{
// If rendezvous is bypassed, enable SoftAP so that the device can still
// be communicated with via its SoftAP as needed.
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}

This comment was generated by todo based on a TODO comment in d8e7a75 in #8369. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-8368 branch from d8e7a75 to 6d8cbfe Compare July 14, 2021 11:21
@todo
Copy link

todo bot commented Jul 14, 2021

(cecille): Fix for the case where BLE and SoftAP are both enabled.`

connectedhomeip/examples/bridge-app/esp32/main/CHIPDeviceManager.cpp

Lines 67 to 77 in 6d8cbfe

// TODO(cecille): Fix for the case where BLE and SoftAP are both enabled.`
ConnectivityMgr().SetBLEAdvertisingEnabled(false);
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}
else
{
// If rendezvous is bypassed, enable SoftAP so that the device can still
// be communicated with via its SoftAP as needed.
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}

This comment was generated by todo based on a TODO comment in 6d8cbfe in #8369. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-8368 branch from 6d8cbfe to 0801599 Compare July 14, 2021 11:44
@todo
Copy link

todo bot commented Jul 14, 2021

(cecille): Fix for the case where BLE and SoftAP are both enabled.`

connectedhomeip/examples/bridge-app/esp32/main/CHIPDeviceManager.cpp

Lines 67 to 77 in 0801599

// TODO(cecille): Fix for the case where BLE and SoftAP are both enabled.`
ConnectivityMgr().SetBLEAdvertisingEnabled(false);
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}
else
{
// If rendezvous is bypassed, enable SoftAP so that the device can still
// be communicated with via its SoftAP as needed.
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}

This comment was generated by todo based on a TODO comment in 0801599 in #8369. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-8368 branch from 0801599 to ce1e5a6 Compare July 14, 2021 12:07
@todo
Copy link

todo bot commented Jul 14, 2021

(cecille): Fix for the case where BLE and SoftAP are both enabled.`

connectedhomeip/examples/bridge-app/esp32/main/CHIPDeviceManager.cpp

Lines 67 to 77 in ce1e5a6

// TODO(cecille): Fix for the case where BLE and SoftAP are both enabled.`
ConnectivityMgr().SetBLEAdvertisingEnabled(false);
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}
else
{
// If rendezvous is bypassed, enable SoftAP so that the device can still
// be communicated with via its SoftAP as needed.
ConnectivityMgr().SetWiFiAPMode(ConnectivityManager::kWiFiAPMode_Enabled);
}

This comment was generated by todo based on a TODO comment in ce1e5a6 in #8369. cc @project-chip.

@restyled-io restyled-io bot closed this Jul 14, 2021
@restyled-io restyled-io bot deleted the restyled/pull-8368 branch July 14, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples restyled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweetymhaiske @restyled-commits